feat: improve dx of kakao map #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Preview: https://vitamin-c-hgyc5wbvb-poiu694s-projects.vercel.app
|
|
The latest updates on your projects. Preview: https://vitamin-c-p6ph1nobx-poiu694s-projects.vercel.app
|
- add 'zoom_changed' event listener - change existing 'level' to 'defaultLevel' - update effect deps
|
The latest updates on your projects. Preview: https://vitamin-c-5ib7jgh5f-poiu694s-projects.vercel.app
|
- remove level state - remove Effect
|
The latest updates on your projects. Preview: https://vitamin-c-2cxwwappm-poiu694s-projects.vercel.app
|
hee-suh
approved these changes
Jul 9, 2024
|
The latest updates on your projects. Preview: https://vitamin-c-ew91w57fv-poiu694s-projects.vercel.app
|
Pridesd
approved these changes
Jul 10, 2024
| const position = new kakao.maps.LatLng(latitude, longitude) | ||
| const content = createMarkerContent(type, iconSize, isSaved, className) | ||
|
|
||
| const customOverlay = new kakao.maps.CustomOverlay({ |
There was a problem hiding this comment.
마커를 이 방식으로 사용할 수 있다는 게 신기하네요..
|
|
||
| if (IconComponent) { | ||
| const baseIcon = createBaseIcon(IconComponent, size) | ||
| container.appendChild(baseIcon) |
There was a problem hiding this comment.
이 부분은 maeker에 이미지 url를 입력하는 게 아니라 marker가 들어가는 공간에 아이콘 컴포넌트를 삽입하는 걸로 이해하면 될까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
feat: add login page)